Zhou Zheng Sheng has posted comments on this change.
Change subject: vdsmd and supervdsmd: extract common init tasks and add init
adapter
......................................................................
Patch Set 18:
(2 comments)
....................................................
File vdsm.spec.in
Line 564: %if 0%{?with_systemd}
Line 565: # Install the systemd scripts
Line 566: # old version of ovirt-host-deploy needs systemd-vdsmd to reconfigure
libvirt
Line 567: install -dDm 0755 %{buildroot}/lib/systemd
Line 568: /bin/ln -s %{_libexecdir}/%{vdsm_name}/vdsmd_init_common.sh
%{buildroot}/lib/systemd/systemd-vdsmd
Thanks for the explanation. I'll take it.
Line 569: install -Dm 0644 vdsm/vdsmd.service
%{buildroot}%{_unitdir}/vdsmd.service
Line 570: install -Dm 0644 vdsm/supervdsmd.service
%{buildroot}%{_unitdir}/supervdsmd.service
Line 571:
Line 572: install -Dm 0644 vdsm/vdsm-restore-net-config.service \
....................................................
File vdsm/vdsmd.init.in
Line 83: fi
Line 84:
Line 85: "${VDSMD_INIT_COMMON}" --shutdown-conflicting-srv
"${CONFLICTING_SERVICES}"
Line 86:
Line 87: "${VDSMD_INIT_COMMON}" --start-needed-srv "${NEEDED_SERVICES}"
This is because each distro can use different pairs of init systems.
Ubuntu: SysV + Upstart, and most of the services is managed by Upstart, a few
is in SysV.
Debian: SysV + SystemD in future, now SysV or OpenRC.
REHL6: SysV + Upstart, and most of the services is managed by SysV, a few is in
Upstart.
RHEL7 and Fedora maybe almost the same I guess, SysV + SystemD.
When writing a SystemD/OpenRC/Upstart service spec, we know for sure the
accompany/legacy init system is SysV. When writing a SysV script, we do not
know the accompany/advanced init system unless you've decided the distro. So do
not know the specific command to start dependency services in general. Debian
has also provided a Debianized SysV init templete in the packaging tool suit.
This means vdsmd.init.in may not suit for Debian. So maybe
"init/debian/vdsmd.init.in" and "init/RHEL6/vdsmd.init.in" will be created.
Moreover, the service names are different in various distros, and there are
some other differences so that each distro would need its own VDSM SysV init
script. Even for SystemD, I'm not sure in future Debian will use the same
service names. So actually we need to customize s distro specific SysV init
scripts, and possibly specific SystemD service spec of VDSM.
So my previous comment is to say, if this vdsmd.init.in is only for RHEL6, we
can change it to use "service" and "initctl" to start dependencies. If not,
we'd better use vdsm-tool which covers different service names and init systems.
Same as vdsm.spec.in, this vdsmd.init.in is actually maintained by VDSM
developers, so there is no burden for external packagers to understand
"start_needed_srv" and vdsm-tool. After all, packaging is not trivial, it
always needs some knowledge of the project itself.
At last, if we all agree this vdsmd.init.in is just for RHEL6, I can update the
patch to use "service" and "initctl" to start the dependencies.
Line 88:
Line 89: "${VDSMD_INIT_COMMON}" --pre-start
Line 90:
Line 91: echo $"Starting up vdsm daemon: "
--
To view, visit http://gerrit.ovirt.org/15578
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id8e514df1ca88500f746242134ddb24c31588046
Gerrit-PatchSet: 18
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Mark Wu <[email protected]>
Gerrit-Reviewer: Mei Liu <[email protected]>
Gerrit-Reviewer: Saggi Mizrahi <[email protected]>
Gerrit-Reviewer: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: Zhou Zheng Sheng <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
