Alon Bar-Lev has posted comments on this change. Change subject: vdsmd and supervdsmd: extract common init tasks and add init adapter ......................................................................
Patch Set 18: (1 comment) .................................................... File vdsm/vdsmd.init.in Line 83: fi Line 84: Line 85: "${VDSMD_INIT_COMMON}" --shutdown-conflicting-srv "${CONFLICTING_SERVICES}" Line 86: Line 87: "${VDSMD_INIT_COMMON}" --start-needed-srv "${NEEDED_SERVICES}" Well, I think that at upstream you can put both: start on started libvirt-bin or started portmap ... start on started libvirtd or ... Or any other syntax... mean the we do not care if service is called X or Y... And: for service in libvirtd libvirt-bin portmaper ...; do if exists "${service}"; then start "${service}" fi done Meaning, I do not care which distro it is... just start the service if exists. Line 88: Line 89: "${VDSMD_INIT_COMMON}" --pre-start Line 90: Line 91: echo $"Starting up vdsm daemon: " -- To view, visit http://gerrit.ovirt.org/15578 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id8e514df1ca88500f746242134ddb24c31588046 Gerrit-PatchSet: 18 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Zhou Zheng Sheng <zhshz...@linux.vnet.ibm.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Antoni Segura Puimedon <asegu...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Mark Wu <wu...@linux.vnet.ibm.com> Gerrit-Reviewer: Mei Liu <liu...@linux.vnet.ibm.com> Gerrit-Reviewer: Saggi Mizrahi <smizr...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: Zhou Zheng Sheng <zhshz...@linux.vnet.ibm.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches