Giuseppe Vallarelli has posted comments on this change. Change subject: vdsm: Reboot capability for VM ......................................................................
Patch Set 17: (1 comment) .................................................... File vdsm/vm.py Line 1619: return m Line 1620: Line 1621: Line 1622: class VmPowerDown(utils.CallbackChain): Line 1623: def __init__(self, vm, info): At this point having both the __init__ and create doesn't have much sense I suggest to remove this one and expose only create. Line 1624: super(VmPowerDown, self).__init__(checkSuccess=info['checkSuccess']) Line 1625: self.vm = vm Line 1626: self.info = info Line 1627: -- To view, visit http://gerrit.ovirt.org/15829 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I12737e363a80679ffb1db55f14eaee158312d7da Gerrit-PatchSet: 17 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Betak <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Giuseppe Vallarelli <[email protected]> Gerrit-Reviewer: Martin Betak <[email protected]> Gerrit-Reviewer: Martin Sivák <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Peter V. Saveliev <[email protected]> Gerrit-Reviewer: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
