Antoni Segura Puimedon has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
......................................................................
Patch Set 18: Code-Review-1
(1 comment)
....................................................
File vdsm/vm.py
Line 1631: super(VmPowerDown, self).start()
Line 1632:
Line 1633: return {'status': {'code': doneCode['code'],
Line 1634: 'message': self.info['returnMsg']}}
Line 1635: except:
Still the wrong exception is being catched. Should presumably be "except
Exception:" instead of just "except:"
Line 1636: self.vm.log.error("{action} failed".format(**self.info),
Line 1637: exc_info=True)
Line 1638: message = 'Failed to {action} VM.'
Line 1639: if not self.force:
--
To view, visit http://gerrit.ovirt.org/15829
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I12737e363a80679ffb1db55f14eaee158312d7da
Gerrit-PatchSet: 18
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Betak <[email protected]>
Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Giuseppe Vallarelli <[email protected]>
Gerrit-Reviewer: Martin Betak <[email protected]>
Gerrit-Reviewer: Martin Sivák <[email protected]>
Gerrit-Reviewer: Michal Skrivanek <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Peter V. Saveliev <[email protected]>
Gerrit-Reviewer: Vinzenz Feenstra <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
