Yeela Kaplan has posted comments on this change.
Change subject: vm: new parameter 'protected' for vm creation
......................................................................
Patch Set 4:
(1 comment)
....................................................
File vdsm/vm.py
Line 1645: """
Line 1646: self._dom = None
Line 1647: self.conf = {
Line 1648: 'pid': '0',
Line 1649: 'protected': config.getboolean('irs',
'use_volume_leases'),
As I understand, this should be a configuration per vm, so how can it be we
take it as a constant from config.py?
Line 1650: }
Line 1651: self.conf.update(params)
Line 1652: self.cif = cif
Line 1653: self.log = SimpleLogAdapter(self.log, {"vmId":
self.conf['vmId']})
--
To view, visit http://gerrit.ovirt.org/17714
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9429ead45caac1178957a33393642817db59508f
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Greg Padgett <[email protected]>
Gerrit-Reviewer: Itamar Heim <[email protected]>
Gerrit-Reviewer: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: Yeela Kaplan <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
