Ayal Baron has posted comments on this change.
Change subject: vm: new parameter 'protected' for vm creation
......................................................................
Patch Set 4:
(2 comments)
....................................................
File vdsm/storage/hsm.py
Line 3255: 'volType': "path"}
Line 3256:
Line 3257: leasePath, leaseOffset = dom.getVolumeLease(imgUUID,
volUUID)
Line 3258:
Line 3259: if leasePath and leaseOffset is not None:
nit - this is checking if leasePath evaluates to True and leaseOffset is not
None. Although the result is what you expect, it is not exactly what you meant
I believe.
e.g.
leasePath = True
leaseOffset = False
above would evaluate to True
Line 3260: volInfo.update({
Line 3261: 'leasePath': leasePath,
Line 3262: 'leaseOffset': leaseOffset,
Line 3263: })
....................................................
File vdsm/vm.py
Line 3213: params=customProps)
Line 3214: return {'status': doneCode, 'vmList': self.status()}
Line 3215:
Line 3216: def hotplugDisk(self, params):
Line 3217: if self.isProtected():
you have a set of criteria which define disks which are not protected, why
block these operations for such disks?
e.g. volInfo.get('shared'....
Line 3218: return errCode['noimpl']
Line 3219:
Line 3220: if self.isMigrating():
Line 3221: return errCode['migInProgress']
--
To view, visit http://gerrit.ovirt.org/17714
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9429ead45caac1178957a33393642817db59508f
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Greg Padgett <[email protected]>
Gerrit-Reviewer: Itamar Heim <[email protected]>
Gerrit-Reviewer: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: Yeela Kaplan <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
