Federico Simoncelli has posted comments on this change. Change subject: Remove redundant check that causes lvm cache to refresh every volume creation ......................................................................
Patch Set 2: (1 comment) .................................................... File vdsm/storage/remoteFileHandler.py Line 349: Line 350: def truncateFile(path, size, mode=None, creatExcl=False): Line 351: flags = os.O_EXCL | os.O_CREAT if creatExcl else "w" Line 352: Line 353: with os.open(path, flags) as f: os.open returns a file descriptor, I don't think it can be used in this way Line 354: if mode is not None: Line 355: os.chmod(path, mode) Line 356: f.truncate(size) Line 357: -- To view, visit http://gerrit.ovirt.org/18274 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib6f3b6ca8313070d0345b5f76ebb0b3d9772d14f Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Yeela Kaplan <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
