Ayal Baron has posted comments on this change.
Change subject: Remove redundant check that causes lvm cache to refresh every
volume creation
......................................................................
Patch Set 6:
(1 comment)
....................................................
File vdsm/storage/fileVolume.py
Line 90: metaVolPath = cls.__metaVolumePath(volPath)
Line 91: cls.log.info("Halfbaked volume rollback for volPath=%s",
volPath)
Line 92:
Line 93: if oop.getProcessPool(sdUUID).fileUtils.pathExists(volPath)
and not \
Line 94:
oop.getProcessPool(sdUUID).fileUtils.pathExists(metaVolPath):
why don't we need a similar check in blockVolume.py ?
Line 95: oop.getProcessPool(sdUUID).os.unlink(volPath)
Line 96:
Line 97: @classmethod
Line 98: def validateCreateVolumeParams(cls, volFormat, preallocate,
srcVolUUID):
--
To view, visit http://gerrit.ovirt.org/18274
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib6f3b6ca8313070d0345b5f76ebb0b3d9772d14f
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Yeela Kaplan <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
