Dan Kenigsberg has posted comments on this change. Change subject: Add IPv6 support to configNetwork ......................................................................
Patch Set 2: Code-Review-1 (2 comments) Please include a test or two for the added functionality. .................................................... File vdsm/configNetwork.py Line 471: ipaddr="<ip>" Line 472: netmask="<ip>" Line 473: gateway="<ip>" Line 474: bootproto="..." Line 475: ipv6addr="<ip>[/<prefixlen>]" better say here explicitly that an <ipv6> address is expected, and that ipaddr is <ipv4>. Line 476: ipv6gateway="<ip>" Line 477: ipv6autoconf="0|1" Line 478: dhcpv6="0|1" Line 479: delay="..." .................................................... File vdsm/netmodels.py Line 43: raise NotImplementedError Line 44: Line 45: @property Line 46: def ipConfig(self): Line 47: return self.ip.getConfig() why have you dropped the try-except? self.ip may still be None if I'm not mistaken. Line 48: Line 49: @property Line 50: def bridge(self): Line 51: if isinstance(self.master, Bridge): -- To view, visit http://gerrit.ovirt.org/18284 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8ed056b683f0cb893b2edcf1ae673c64ce5cd18c Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Šebek <pse...@redhat.com> Gerrit-Reviewer: Antoni Segura Puimedon <asegu...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Petr Šebek <pse...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches