Assaf Muller has posted comments on this change. Change subject: Add IPv6 support to configNetwork ......................................................................
Patch Set 4: Verified-1 (1 comment) They are. I explained in an inline comment. .................................................... File vdsm/netmodels.py Line 411: 'bootproto', 'async', 'ipv6autoconf', Line 412: 'dhcpv6']) Line 413: Line 414: def __init__(self, inet4=None, inet6=None, bootproto=None, blocking=False, Line 415: ipv6autoconf=None, dhcpv6=None): It used to be valid for the ipaddr, netmask, gateway and bootproto fields to be None (For example if from the webadmin you choose None as the boot proto). Now you raise an exception if you didn't get an ip configuration, which is the reason that the functional tests are failing. Most functional tests we don't pass it in an ip configuration. Line 416: if inet4 is None and inet6 is None: Line 417: raise ConfigNetworkError(ne.ERR_BAD_ADDR, 'You need to specify ' Line 418: 'IPv4 or IPv6 or both address.') Line 419: if ((inet4 and inet4.address and bootproto == 'dhcp') or -- To view, visit http://gerrit.ovirt.org/18284 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8ed056b683f0cb893b2edcf1ae673c64ce5cd18c Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Šebek <pse...@redhat.com> Gerrit-Reviewer: Antoni Segura Puimedon <asegu...@redhat.com> Gerrit-Reviewer: Assaf Muller <amul...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Petr Šebek <pse...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
