Dan Kenigsberg has posted comments on this change.
Change subject: tests: setupNetworks with invalid params.
......................................................................
Patch Set 7: Code-Review-1
(2 comments)
....................................................
File tests/functional/networkTests.py
Line 687: attrs = dict(vlan=VLAN_ID, bridged=bridged)
Line 688: status, msg = self.vdsm_net.setupNetworks({NETWORK_NAME:
attrs},
Line 689: {}, {})
Line 690:
Line 691: self.assertTrue(status != SUCCESS, msg)
self.assertEquals(status, SUCCESS, msg) give a nicer more informative output on
error.
....................................................
File tests/netmodelsTests.py
Line 59: self.assertEqual(cneContext.exception.errCode,
Line 60: neterrors.ERR_BAD_BRIDGE)
Line 61:
Line 62: def testIsNicValid(self):
Line 63: invalidNicName = ('toni', 'livnat', 'dan')
I'm not offended.
Line 64:
Line 65: class FakeNetInfo(object):
Line 66: def __init__(self):
Line 67: self.nics = ['eth0', 'eth1']
--
To view, visit http://gerrit.ovirt.org/17435
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic77b3a9c0d84e38e8b9060191b138c3e09104dc6
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Giuseppe Vallarelli <[email protected]>
Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Giuseppe Vallarelli <[email protected]>
Gerrit-Reviewer: Livnat Peer <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
