Giuseppe Vallarelli has posted comments on this change.

Change subject: tests: setupNetworks with invalid params.
......................................................................


Patch Set 7:

(1 comment)

....................................................
File tests/functional/networkTests.py
Line 687:         attrs = dict(vlan=VLAN_ID, bridged=bridged)
Line 688:         status, msg = self.vdsm_net.setupNetworks({NETWORK_NAME: 
attrs},
Line 689:                                                   {}, {})
Line 690: 
Line 691:         self.assertTrue(status != SUCCESS, msg)
just realized that I should have used assertNotEqual instead.


-- 
To view, visit http://gerrit.ovirt.org/17435
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic77b3a9c0d84e38e8b9060191b138c3e09104dc6
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Giuseppe Vallarelli <[email protected]>
Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Giuseppe Vallarelli <[email protected]>
Gerrit-Reviewer: Livnat Peer <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to