Bala.FA has posted comments on this change.
Change subject: gluster: Using XML output for rebalance/remove-brick status
verbs
......................................................................
Patch Set 4: Code-Review-1
(4 comments)
....................................................
Commit Message
Line 10: output provided by gluster cli command.
Line 11:
Line 12: Modified verbs:
Line 13: glusterVolumeRebalanceStatus
Line 14: glusterVolumeRemoveBrickStatus
You also add that this modification doesn't break backward compatibility
because of its wasn't consumed yet.
Line 15:
Line 16: Change-Id: I7d277f267cf64d8af419d07367c33dc065f86a9b
Line 17: Signed-off-by: Bala.FA <barum...@redhat.com>
....................................................
File vdsm/gluster/cli.py
Line 648: 'filesMoved':
int(el.find('files').text),
Line 649: 'filesFailed':
int(el.find('failures').text),
Line 650: 'filesSkipped': 0,
Line 651: 'totalSizeMoved':
int(el.find('size').text),
Line 652: 'status':
_getStatus(el.find('status').text)})
the xml output supposes to have status as string too. If not, please file a
bug and treat this behavior as workaround till its getting fixed.
Please add comments about this workaround.
Line 653:
Line 654: if len(nodesStatus) == 1:
Line 655: status['summary']['status'] = _getStatus(nodesStatus.pop())
Line 656: else:
Line 651: 'totalSizeMoved':
int(el.find('size').text),
Line 652: 'status':
_getStatus(el.find('status').text)})
Line 653:
Line 654: if len(nodesStatus) == 1:
Line 655: status['summary']['status'] = _getStatus(nodesStatus.pop())
1. Doesn't gluster cli provide status of the task in <aggregate>? If yes, its
a bug in gluster cli output, please file a bug and add comments abt this
workaround.
2. What this workaround should set if nodes are in different state? why assume
first state in the set is correct?
Line 656: else:
Line 657: status['summary']['status'] = TaskStatus.STARTED
Line 658: return status
Line 659:
Line 653:
Line 654: if len(nodesStatus) == 1:
Line 655: status['summary']['status'] = _getStatus(nodesStatus.pop())
Line 656: else:
Line 657: status['summary']['status'] = TaskStatus.STARTED
Why you assume its STARTED? Isn't it UNKNOWN?
Line 658: return status
Line 659:
Line 660:
Line 661: @makePublic
--
To view, visit http://gerrit.ovirt.org/18358
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7d277f267cf64d8af419d07367c33dc065f86a9b
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Aravinda VK <avish...@redhat.com>
Gerrit-Reviewer: Aravinda VK <avish...@redhat.com>
Gerrit-Reviewer: Bala.FA <barum...@redhat.com>
Gerrit-Reviewer: Timothy Asir <tjeya...@redhat.com>
Gerrit-Reviewer: ndarshan <dnara...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
