Bala.FA has posted comments on this change.
Change subject: gluster: Using XML output for rebalance/remove-brick status
verbs
......................................................................
Patch Set 7: Code-Review-1
(4 comments)
....................................................
Commit Message
Line 11:
Line 12: Modified verbs(As below verbs are not consumed by engine/RHS-C yet,
Line 13: its OK to differ in compatibility issue now)
Line 14: glusterVolumeRebalanceStatus
Line 15: glusterVolumeRemoveBrickStatus
Please add new output structure of these verbs
Line 16:
Line 17: Change-Id: I7d277f267cf64d8af419d07367c33dc065f86a9b
Line 18: Signed-off-by: Bala.FA <barum...@redhat.com>
....................................................
File tests/Makefile.am
Line 90: glob_1c60971a-8647-44ac-ae33-6520887f8843.out \
Line 91: glusterVolumeProfileInfo.xml \
Line 92: glusterVolumeProfileInfoNfs.xml \
Line 93: glusterVolumeRebalanceStatus.xml \
Line 94: glusterVolumeRemoveBricksStatus.xml \
whitespace at the end
Line 95: lvs_3386c6f2-926f-42c4-839c-38287fac8998.out \
Line 96: netmaskconversions \
Line 97: tc_filter_show.out \
Line 98: $(NULL)
....................................................
File tests/glusterTestData.py
Line 765: 'totalWrite': '0'}}],
Line 766: 'volumeName': 'music2'}
Line 767:
Line 768:
Line 769: REBAL_REM_BRICK_STATUS = {
You could name the variable this better
Line 770: 'summary': {
Line 771: 'filesScanned': 278,
Line 772: 'filesMoved': 78,
Line 773: 'filesFailed': 0,
....................................................
File vdsm/gluster/cli.py
Line 624: 'filesMoved':
int(el.find('files').text),
Line 625: 'filesFailed':
int(el.find('failures').text),
Line 626: 'filesSkipped':
int(el.find('skipped').text),
Line 627: 'totalSizeMoved':
int(el.find('size').text),
Line 628: 'status':
el.find('statusStr').text.upper()})
whitespace at the end
Line 629:
Line 630: return status
Line 631:
Line 632:
--
To view, visit http://gerrit.ovirt.org/18358
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7d277f267cf64d8af419d07367c33dc065f86a9b
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Aravinda VK <avish...@redhat.com>
Gerrit-Reviewer: Aravinda VK <avish...@redhat.com>
Gerrit-Reviewer: Bala.FA <barum...@redhat.com>
Gerrit-Reviewer: Timothy Asir <tjeya...@redhat.com>
Gerrit-Reviewer: ndarshan <dnara...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
