Dan Kenigsberg has posted comments on this change.
Change subject: Normalize lvm._buildFilter().
......................................................................
Patch Set 1: Code-Review-1
(1 comment)
I like the idea, but I think it can become even better.
....................................................
File vdsm/storage/lvm.py
Line 128:
Line 129:
Line 130: def _buildFilter(devices):
Line 131: strippeds = sorted(set(d.strip() for d in devices))
Line 132: strippeds.discard('') # Who has put a blank here?
the same one who put insignificant trailing spaces into device names. I am
guessing that the stripping and discarding should be done ONLY when calculating
USER_DEV_LIST.
Line 133: dmPaths = []
Line 134: for dev in strippeds:
Line 135: dmPath = os.path.join(PV_PREFIX, dev)
Line 136: dmPaths.append(dmPath.replace(r'\x', r'\\x'))
--
To view, visit http://gerrit.ovirt.org/17966
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2c0a5c61ba6754db996b2c88b32bedee852df22f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Elad Ben Aharon <[email protected]>
Gerrit-Reviewer: Yeela Kaplan <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
