Ayal Baron has posted comments on this change.
Change subject: Normalize lvm._buildFilter().
......................................................................
Patch Set 2:
(1 comment)
....................................................
File vdsm/storage/lvm.py
Line 131: strippeds = set(d.strip() for d in devices)
Line 132: strippeds.discard('') # Who has put a blank here?
Line 133: strippeds = sorted(strippeds)
Line 134: dmPaths = [dev.replace(r'\x', r'\\x') for dev in strippeds]
Line 135: filt = '|'.join(dmPaths)
filt = '|'.join(set(sorted(dmPaths))
Line 136: if len(filt) > 0:
Line 137: filt = "'a|" + filt + "|', "
Line 138:
Line 139: filt = "filter = [ " + filt + "'r|.*|' ]"
--
To view, visit http://gerrit.ovirt.org/17966
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2c0a5c61ba6754db996b2c88b32bedee852df22f
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewars...@redhat.com>
Gerrit-Reviewer: Ayal Baron <aba...@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: Eduardo <ewars...@redhat.com>
Gerrit-Reviewer: Elad Ben Aharon <eladba1...@gmail.com>
Gerrit-Reviewer: Yeela Kaplan <ykap...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
