Dan Kenigsberg has posted comments on this change.
Change subject: Testcase vlaned network to bridgeless
......................................................................
Patch Set 1: Code-Review-1
(1 comment)
....................................................
File tests/functional/networkTests.py
Line 1147: status, msg = self.vdsm_net.setupNetworks(networks,
{}, {})
Line 1148: self.assertEqual(status, SUCCESS, msg)
Line 1149:
self.assertTrue(self.vdsm_net.networkExists(NETWORK_NAME))
Line 1150:
self.assertTrue(self.vdsm_net.networkExists(vlan_name))
Line 1151: ifcfg_file = '/etc/sysconfig/network-scripts/ifcfg-'
+ \
we actually care about the API, not the file per se. Please call getCaps and
check if the 'cfg' element exists and that the 'BOOTPROTO' element within it it
correct.
Line 1152: NETWORK_NAME
Line 1153: self.assertTrue(os.path.isfile(ifcfg_file))
Line 1154: delete_networks = {NETWORK_NAME: {'remove': True},
Line 1155: vlan_name: {'remove': True}}
--
To view, visit http://gerrit.ovirt.org/18911
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I97ac3464736ac1e8cc4e31cb3a1f5e4db7ee9ebb
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Šebek <pse...@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
