Dan Kenigsberg has posted comments on this change.
Change subject: Fix missing bootproto line
......................................................................
Patch Set 6: Code-Review-1
(3 comments)
....................................................
File vdsm/netconf/ifcfg.py
Line 140: self._removeSourceRoute(vlan)
Line 141: self.configApplier.removeVlan(vlan.name)
Line 142: # we don't want to delete device nic, because vlan did not
touch it
Line 143: # and it might be used by another bridgeless network
Line 144: if vlan.device.isBond():
but if there is NO bridgeless network using this device? and why is it specific
to bonding? Wouldn't the same thing occur if a regular nic is used by both
bridgeless network and a vlan'ed network?
the base device should be removed iff its ifaceUsers() is empty.
Line 145: vlan.device.remove()
Line 146:
Line 147: def _ifaceDownAndCleanup(self, iface, _netinfo):
Line 148: """Returns True iff the iface is to be removed."""
Line 459: def writeConfFile(self, fileName, configuration):
Line 460: '''Backs up the previous contents of the file referenced by
fileName
Line 461: writes the new configuration and sets the specified access
mode.'''
Line 462: self._backup(fileName)
Line 463: logging.info('Writing to file %s configuration:\n%s' %
(fileName,
this has to be low of a low DEBUG level, not info.
Line 464: configuration))
Line 465: open(fileName, 'w').write(configuration)
Line 466: os.chmod(fileName, 0664)
Line 467: try:
....................................................
File vdsm/netmodels.py
Line 75: return self.master
Line 76: return None
Line 77:
Line 78: def isBond(self):
Line 79: if isinstance(self, Bond):
return isinstance(self, Bond)
is just as good, but cleaner (in case we actually need this function)
Line 80: return True
Line 81: else:
Line 82: return False
Line 83:
--
To view, visit http://gerrit.ovirt.org/18911
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I97ac3464736ac1e8cc4e31cb3a1f5e4db7ee9ebb
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Šebek <pse...@redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegu...@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
