Dan Kenigsberg has posted comments on this change.

Change subject: remoteFileHandler: config logging in spawned process
......................................................................


Patch Set 7:

(1 comment)

....................................................
File vdsm/storage/remoteFileHandler.py
Line 46: import misc
Line 47: import fileUtils
Line 48: import zombieReaper
Line 49: from vdsm import constants
Line 50: 
I am so sorry that I did not notice your response and question. Yes, using 
syslog to queue the log messages is acceptable - if you can do that by dropping 
a file into /etc/rsyslog.d. I wouldn't mind if you queue vdsm-propper log 
messages so that we have one linear /var/log/vdsm/vdsm.log with everything 
inside.
Line 51: 
Line 52: # Crabs are known for their remote process calls
Line 53: LENGTH_STRUCT_FMT = "Q"
Line 54: LENGTH_STRUCT_LENGTH = calcsize(LENGTH_STRUCT_FMT)


-- 
To view, visit http://gerrit.ovirt.org/9182
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1b3b9e2837d632c7532fcd8f7306ed50b0865b5c
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng <zhshz...@linux.vnet.ibm.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com>
Gerrit-Reviewer: Mark Wu <wu...@linux.vnet.ibm.com>
Gerrit-Reviewer: Saggi Mizrahi <smizr...@redhat.com>
Gerrit-Reviewer: ShaoHe Feng <shao...@linux.vnet.ibm.com>
Gerrit-Reviewer: Shu Ming <shum...@linux.vnet.ibm.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshz...@linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to