Martin Sivák has posted comments on this change. Change subject: vdsm: Reboot capability for VM ......................................................................
Patch Set 23: Dan: IIRC the checkSuccess approach was just a convenient way of doing this without having to pass the callback result between threads. And the check was the same for the whole chain so we avoided a slight code duplication as well. But if we are splitting the patch into a general utility CallbackChain class and VmPowerDown that uses it, then having separate and possibly different check for each step also makes sense. My comments were actually meant as a summary (that is why I gave no score) of all the complaints I heard compiled into a reasonable form. I would personally still prefer much more declarative approach. Martin will be back at noon so he will probably add comments later. Btw, how do you unittest threading class? Integration/functional tests are quite possible, but mocking thread behaviour to achieve unittest isolation? I would love to see a unittest for thread class, but I have not found any satisfactory way of doing it so far. -- To view, visit http://gerrit.ovirt.org/15829 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I12737e363a80679ffb1db55f14eaee158312d7da Gerrit-PatchSet: 23 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Betak <mbe...@redhat.com> Gerrit-Reviewer: Antoni Segura Puimedon <asegu...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com> Gerrit-Reviewer: Giuseppe Vallarelli <gvall...@redhat.com> Gerrit-Reviewer: Martin Betak <mbe...@redhat.com> Gerrit-Reviewer: Martin Sivák <msi...@redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Peter V. Saveliev <p...@redhat.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeen...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
