Martin Betak has posted comments on this change.

Change subject: vdsm: Reboot capability for VM
......................................................................


Patch Set 22:

(1 comment)

....................................................
File vdsm/guestIF.py
Line 298:             self._forward('log-off')
Line 299:         except:
Line 300:             self.log.error("desktopLogoff failed", exc_info=True)
Line 301: 
Line 302:     def desktopShutdown(self, timeout, msg, reboot):
Since there is currently no way to determine the features supported (api 
version) by the guest agent I cannot think of any way to improve upon this 
behavior.
Line 303:         try:
Line 304:             self.log.debug("desktopShutdown called")
Line 305:             self._forward('shutdown', {'timeout': timeout, 'message': 
msg,
Line 306:                                        'reboot': reboot})


-- 
To view, visit http://gerrit.ovirt.org/15829
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I12737e363a80679ffb1db55f14eaee158312d7da
Gerrit-PatchSet: 22
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Betak <mbe...@redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegu...@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com>
Gerrit-Reviewer: Giuseppe Vallarelli <gvall...@redhat.com>
Gerrit-Reviewer: Martin Betak <mbe...@redhat.com>
Gerrit-Reviewer: Martin Sivák <msi...@redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Peter V. Saveliev <p...@redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeen...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to