Alon Bar-Lev has posted comments on this change.
Change subject: Removing automatic restart of services in libvirt-reconfigure
......................................................................
Patch Set 7:
(1 comment)
....................................................
File init/sysvinit/vdsmd.init.in
Line 123: "$VDSM_TOOL" libvirt-configure
Line 124: fi
Line 125: RETVAL=$?
Line 126: [ "$RETVAL" = 0 ] && "$VDSM_TOOL"
libvirt-configure-services-restart
Line 127: return "$RETVAL"
Another option:
reconfigure_libvirt() {
local force
[ "$1" = "force" ] && force="--force"
"${VDSM_TOOL}" libvirt-configure ${force} && "${VDSM_TOOL}"
libvirt-configure-services-restart
}
better, no?
Line 128: }
Line 129:
Line 130: start() {
Line 131: local ret_val
--
To view, visit http://gerrit.ovirt.org/18780
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If3711da62d6c196978fb4f5e89f1bce4b7500470
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybron...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshz...@linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
