Yaniv Bronhaim has posted comments on this change. Change subject: Removing automatic restart of services in libvirt-reconfigure ......................................................................
Patch Set 9: (1 comment) .................................................... File lib/vdsm/tool/libvirt_configure.py Line 59: To start working with new configuration execute: Line 60: vdsm-tool libvirt_configure_services_restart Line 61: This will manage stop and start to the following services: Line 62: libvirtd, supervdsmd Line 63: """) somehow I thought you've already merged the patch, anyway this print appears each restart as the restart reconfigure, and it prints it also if libvirt was already configured. To fix it i can return something else than 0 when libvirt is already configured, but some might rely on getting 0 here, so is it fine to leave the msg each run ? any other suggestion? Line 64: Line 65: return ret Line 66: Line 67: -- To view, visit http://gerrit.ovirt.org/18780 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If3711da62d6c196978fb4f5e89f1bce4b7500470 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: Zhou Zheng Sheng <zhshz...@linux.vnet.ibm.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
