Yaniv Bronhaim has posted comments on this change. Change subject: Handling errors in daemonAdapter ......................................................................
Patch Set 16: (1 comment) .................................................... File init/daemonAdapter Line 29: Line 30: Line 31: class DaemonAdapter(object): Line 32: def __init__(self): Line 33: self._args = None so its either this with one function instead of a class or http://gerrit.ovirt.org/#/c/18810/14/init/daemonAdapter , the latter more useful for future use .. I also prefer the old form. Dan, any rejections? Line 34: Line 35: def _parse_args(self): Line 36: parser = argparse.ArgumentParser( Line 37: description='Start daemon process with various daemon options') -- To view, visit http://gerrit.ovirt.org/18810 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib515b01f06331d744b40236af5a1b12a16c37871 Gerrit-PatchSet: 16 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Zhou Zheng Sheng <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
