Alon Bar-Lev has posted comments on this change.
Change subject: Handling errors in daemonAdapter
......................................................................
Patch Set 18:
(1 comment)
....................................................
File init/daemonAdapter
Line 35: self._parse_args()
Line 36: except:
Line 37: self._log("daemonAdapter: Error in parsing inline
arguments: %s" %
Line 38: traceback.print_exc())
Line 39: raise
you should chose:
1. you pass exceptions (always) past of python scope.
2. you handle the error message and explicit exit code.
but please be consistent.
Line 40:
Line 41: def _parse_args(self):
Line 42: parser = argparse.ArgumentParser(
Line 43: description='Start daemon process with various daemon
options')
--
To view, visit http://gerrit.ovirt.org/18810
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib515b01f06331d744b40236af5a1b12a16c37871
Gerrit-PatchSet: 18
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: Zhou Zheng Sheng <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
