Alon Bar-Lev has posted comments on this change.

Change subject: Removing automatic restart of services in libvirt-reconfigure
......................................................................


Patch Set 12:

(2 comments)

....................................................
File lib/vdsm/tool/libvirt_configure.py
Line 54:     libvirt configuration (--force for reconfigure)
Line 55:     """
Line 56:     ret = exec_libvirt_configure("reconfigure",
Line 57:                                  *args)
Line 58:     return ret
return exec ... ?
Line 59: 
Line 60: 
Line 61: @vdsm.tool.expose("libvirt-test-conflicts")
Line 62: def test_conflict_configurations(*args):


Line 73:     """
Line 74:     service.service_stop("supervdsmd")
Line 75:     service.service_stop("libvirtd")
Line 76:     service.service_start("libvirtd")
Line 77:     service.service_start("supervdsmd")
return?


-- 
To view, visit http://gerrit.ovirt.org/18780
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If3711da62d6c196978fb4f5e89f1bce4b7500470
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybron...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshz...@linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to