Dan Kenigsberg has posted comments on this change. Change subject: Log client address on SSL errors ......................................................................
Patch Set 3: Code-Review+2 (1 comment) .................................................... File lib/vdsm/SecureXMLRPCServer.py Line 115: # Create the SSL connection: Line 116: self.connection = SSL.Connection(self.context, sock=raw) Line 117: Line 118: def accept(self): Line 119: # First we need to call the accept method of the raw I expected this to be even more similar to M2Crypto.SSL.Connection.accept()... But come to think about it - to avoid GPL/MIT collisions, better keep your code as it is. Line 120: # socket and build a new SSL connection object with the Line 121: # results: Line 122: client, address = self.connection.socket.accept() Line 123: client = SSL.Connection(self.context, client) -- To view, visit http://gerrit.ovirt.org/19332 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icaed8689bc8bb5bee5fed450646b2c5e9ef42bc1 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
