David Caro has posted comments on this change. Change subject: Log client address on SSL errors ......................................................................
Patch Set 4: Here's an explanation for the jenkinsfailures of the latest patch (I don't say that they are OK, just the reason why they failed): http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4499/ It failed in one of the tests (testBadMethod) before even checking the pep8, because of timeout (we would have to work with a developer to investigate further). The previous runs failed because of the pep8 violation. http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4418/ It did detect the pep8 failure, but was configured to not fail if there is only 1 failure (changed already) http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3602 Failed due to pep8, you can see it in the last logs: lib/vdsm/SecureXMLRPCServer.py:143:1: E303 too many blank lines (3) -- To view, visit http://gerrit.ovirt.org/19332 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icaed8689bc8bb5bee5fed450646b2c5e9ef42bc1 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: David Caro <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-HasComments: No _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
