Dan Kenigsberg has submitted this change and it was merged.
Change subject: Fix missing bootproto line
......................................................................
Fix missing bootproto line
Bootproto of new network was overwritten by value in ifcfg file. That
file lacked BOOTPROTO value and therefore it was stated as None value
(not str).
Bootproto was deleted by function _removeConfigValues because deleted
vlan called function vlan.device.remove() -> Nic.remove().
Patchset 4 fixes usecase tested by testAddVlanedBridgeless_oneCommand.
Patchset 6 log ifcfg files that are written
fixes usecase tested by testAddVlanedBridgeless
added function isBond() to NetDevice
Patchset 7 removed needless functions removeIfaceCleanup and
_removeConfigValues
in _getIfaceConfValues is given priority to network setup
over current configuration in cfg file
Change-Id: I97ac3464736ac1e8cc4e31cb3a1f5e4db7ee9ebb
Bug-Url: https://bugzilla.redhat.com/980174
Signed-off-by: Petr Sebek <[email protected]>
Reviewed-on: http://gerrit.ovirt.org/18911
Reviewed-by: Dan Kenigsberg <[email protected]>
Tested-by: Dan Kenigsberg <[email protected]>
---
M tests/functional/networkTests.py
M vdsm/netconf/ifcfg.py
2 files changed, 81 insertions(+), 21 deletions(-)
Approvals:
Dan Kenigsberg: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/18911
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I97ac3464736ac1e8cc4e31cb3a1f5e4db7ee9ebb
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Šebek <[email protected]>
Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Petr Šebek <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
