Dan Kenigsberg has posted comments on this change. Change subject: Manage test dummies at the module level ......................................................................
Patch Set 5: Code-Review-1 (1 comment) .................................................... File tests/functional/networkTests.py Line 65: Line 66: @contextmanager Line 67: def dummyIf(num): Line 68: """Manages a list of num dummy interfaces. Assumes root privileges.""" Line 69: dummies = [] no need for the first assignment, I believe. Line 70: dummies = [dummyPool.pop() for _ in range(num)] Line 71: try: Line 72: yield dummies Line 73: finally: -- To view, visit http://gerrit.ovirt.org/19650 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5c040fc3175b5760728d749578728be60c75cb9b Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Assaf Muller <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Mark Wu <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
