Assaf Muller has posted comments on this change. Change subject: Manage test dummies at the module level ......................................................................
Patch Set 8: (1 comment) .................................................... File tests/functional/networkTests.py Line 50: Line 51: def setupModule(): Line 52: """Persists network configuration.""" Line 53: vdsm = VdsProxy() Line 54: vdsm.save_config() The maximum number of nics should probably be a constant at the top of the module. Line 55: for _ in range(5): Line 56: dummyPool.add(dummy.create()) Line 57: Line 58: -- To view, visit http://gerrit.ovirt.org/19650 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5c040fc3175b5760728d749578728be60c75cb9b Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Assaf Muller <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Mark Wu <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
