Ayal Baron has posted comments on this change.
Change subject: Enable VM migration to old vdsm's.
......................................................................
Patch Set 2: Code-Review-1
(1 comment)
....................................................
File vdsm/storage/blockSD.py
Line 1035: try:
Line 1036: os.symlink(imgPath, dst)
Line 1037: except OSError as e:
Line 1038: if e.errno == errno.EEXIST:
Line 1039: self.log.debug("img run dir already exists: %s", dst)
What?
I have a stale link there to the wrong image dir (from a previous run VM which
wasn't cleaned because host crashed or whatever) and since then user ran
liveStorageMigration and moved the disk to a new sd.
I think this is a bug.
Also, this is not runVM context, we're in blockSD
Please fix
Line 1040: else:
Line 1041: self.log.error("Failed to create img run dir: %s",
dst)
Line 1042: raise
Line 1043: return dst
--
To view, visit http://gerrit.ovirt.org/19825
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia778ad743a11b4c1d212857d8f25c81eb4c0defe
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewars...@redhat.com>
Gerrit-Reviewer: Ayal Baron <aba...@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: Eduardo <ewars...@redhat.com>
Gerrit-Reviewer: Gadi Ickowicz <gicko...@redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykap...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
