Eduardo has posted comments on this change.
Change subject: Enable VM migration to old vdsm's.
......................................................................
Patch Set 2:
(1 comment)
....................................................
File vdsm/storage/blockSD.py
Line 1035: try:
Line 1036: os.symlink(imgPath, dst)
Line 1037: except OSError as e:
Line 1038: if e.errno == errno.EEXIST:
Line 1039: self.log.debug("img run dir already exists: %s", dst)
Stale link to where? There are not too many dst that can be there.
Link to the image are created by other functions too and the net result is the
same, linking the block image.
This method is only called from vm.py.
Running again the same VM, activating the dame SD/image, will result in the
same link.
In the case you described, you are talking about removing something that we
don't know what is, assuming that is engine trying to run a VM with an image
that is not (but was) in this SD.
This is a serious engine bug, and it should be solved in the LSM.
Having the same image UUID in two SDs, only engine can determine which is the
correct one.
Line 1040: else:
Line 1041: self.log.error("Failed to create img run dir: %s",
dst)
Line 1042: raise
Line 1043: return dst
--
To view, visit http://gerrit.ovirt.org/19825
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia778ad743a11b4c1d212857d8f25c81eb4c0defe
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Eduardo <[email protected]>
Gerrit-Reviewer: Gadi Ickowicz <[email protected]>
Gerrit-Reviewer: Yeela Kaplan <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
