Dan Kenigsberg has posted comments on this change. Change subject: Get rid of mutables(lists) as default parameters ......................................................................
Patch Set 2: Code-Review-1 (1 comment) Keep the initiative! .................................................... File vdsm/storage/misc.py Line 123: Line 124: return False Line 125: Line 126: Line 127: def findCaller(skipUp=0, ignoreSourceFiles=None, ignoreMethodNames=None, Wouldn't ignoreMethodNames=() be enough? Line 128: logSkipName=None): Line 129: """ Line 130: Find the stack frame of the caller so that we can note the source Line 131: file name, line number and function name. -- To view, visit http://gerrit.ovirt.org/18356 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I911485cf30d587f5b6b8bf44cf3552c1517abfd5 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Better Saggi <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Giuseppe Vallarelli <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
