Dan Kenigsberg has posted comments on this change. Change subject: Get rid of mutables(lists) as default parameters ......................................................................
Patch Set 2: (1 comment) .................................................... File vdsm/gluster/exception.py Line 37: code = 4100 Line 38: message = "Gluster Exception" Line 39: rc = 0 Line 40: out = [] Line 41: err = [] Actually they should be dropped completely. I see no reason to make them (and rc) class vars. Line 42: Line 43: def __init__(self, rc=0, out=None, err=None): Line 44: self.rc = rc Line 45: self.out = [] if out is None else out -- To view, visit http://gerrit.ovirt.org/18356 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I911485cf30d587f5b6b8bf44cf3552c1517abfd5 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Better Saggi <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Giuseppe Vallarelli <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
