Dan Kenigsberg has posted comments on this change.
Change subject: Add IPv6 support to configNetwork
......................................................................
Patch Set 9: Code-Review-1
(3 comments)
....................................................
File vdsm/sourceRoute.py
Line 49: self.rules = None
Line 50:
Line 51: def _generateTableId(self):
Line 52: #TODO: Future proof for IPv6
Line 53: return netaddr.IPAddress(self.ipaddr.split('/')[0]).value
I could use a comment about this change. Why is it needed? How is it harmless
to former use cases?
Line 54:
Line 55: def _buildRoutes(self):
Line 56: return [Route(network='0.0.0.0/0', ipaddr=self.gateway,
Line 57: device=self.device, table=self.table),
Line 93: def remove(self):
Line 94: self.configurator.removeSourceRoute(None, None, self.device)
Line 95:
Line 96:
Line 97: class StaticIPv6SourceRoute(StaticSourceRoute):
could you explain why this class is urgently required?
Line 98: def __init__(self, device, configurator):
Line 99: super(StaticIPv6SourceRoute, self).__init__(device,
configurator)
Line 100:
Line 101: def _buildRoutes(self):
Line 110: return
Line 111:
Line 112: addr = ipaddr.split('/')
Line 113: self.ipaddr = addr[0]
Line 114: self.prefixlen = addr[1] if len(addr) > 1 else '0'
why do we need self.prefixlen? why is it a string?
Line 115: self.gateway = gateway.split('/')[0]
Line 116: self.table = self._generateTableId()
Line 117: self.network = ipaddr
Line 118:
--
To view, visit http://gerrit.ovirt.org/18284
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8ed056b683f0cb893b2edcf1ae673c64ce5cd18c
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Šebek <pse...@redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegu...@redhat.com>
Gerrit-Reviewer: Assaf Muller <amul...@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: Kiril Nesenko <knese...@redhat.com>
Gerrit-Reviewer: Petr Šebek <pse...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
