Yaniv Bronhaim has posted comments on this change. Change subject: Adding ppc64 handling to getVdsCaps ......................................................................
Patch Set 9: (2 comments) one comment about raising specific exceptions. did you verify it? .................................................... File vdsm/caps.py Line 106: return self._info.itervalues().next()['model name'] Line 107: elif self.arch == constants.Architecture.PPC64: Line 108: return self._info.itervalues().next()['cpu'] Line 109: else: Line 110: raise Exception('Unsupported architecture') raise specific exception Line 111: Line 112: Line 113: class CpuTopology(object): Line 114: def __init__(self, capabilities=None): Line 213: Line 214: try: Line 215: return ['model_' + getCpuModel()] Line 216: except Exception as e: Line 217: raise Exception('Failed to retrieve CPU model: ' + str(e)) raise RuntimeError , or another specific exception. I would log it with full stacktrace instead of printing e. Line 218: Line 219: c = libvirtconnection.get() Line 220: allModels = _getAllCpuModels() Line 221: -- To view, visit http://gerrit.ovirt.org/17437 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I42c4d00ace06805edbe765d975b40c9311a1fa9b Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vitor de Lima <vitor.l...@eldorado.org.br> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa <gustavo.pedr...@eldorado.org.br> Gerrit-Reviewer: Leonardo Bianconi <leonardo.bianc...@eldorado.org.br> Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeen...@redhat.com> Gerrit-Reviewer: Vitor de Lima <vitor.l...@eldorado.org.br> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches