Nir Soffer has posted comments on this change. Change subject: fcp: Deactivate vdsm volume groups during boot ......................................................................
Patch Set 1: > If vdsm does not support this state, why not just fix vdsm? There is nothing to fix in vdsm - it is the system configuration that is broken here. vdsm must have complete control over its volumes - they should not be activated behind vdsm back. There may be another option to solve this entirely within vdsm. When connecting to FC storage domain, vdsm could deactivate all vgs. However, vdsm does not get an event when connecting to FC storage domain, since it was considered always connected. This options requires adding a new singal to engine, and handling all the possible cases (new vdsm, old engine, old vds, new engine, etc.) Since we need the fix for current customers using released versions (see related bug), I don't think it is the best approach. > Why not add this command to pre-start of vdsm? I considered it, but this solution seems much simpler. Why do you think it is better? > I am sure there is some method to configure system to not start if that what > is actually require without this script. Not sure what do you mean. > This script breaks systemd, upstrart support, and should not be added. Proper scripts and configuration files for systemd and upstart will be added later. Please review what we have here now. -- To view, visit http://gerrit.ovirt.org/20720 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8f72a68ad09566ba222aa45448c78d1577c40d21 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
