Ayal Baron has posted comments on this change. Change subject: fcp: Deactivate vdsm volume groups during boot ......................................................................
Patch Set 1: "1. if connection of new volume group can happen post boot, how come adding anything to init script solves the issue?" As explained in the commit message, auto activation is done by: /etc/rc.sysinit and/or /etc/init.d/netfs so post boot the added VGs will not be auto activated. "2. consider using udev rule, maybe it will solve the issue post boot as well." This would be a big no no as it would be fighting with vdsm when we actually do need to activate "3. consider that on startup vdsm will perform whatever action you do here via svdsm, doing so in startup is similar to doing this on boot." vdsm can restart while there are running VMs, doing this on startup would cut the storage from under their feet. This should be done only once, only on startup, right after the system erroneously activates these VGs (or preferably, just prevent them from being activated in the first place, but we couldn't find a reasonable way of doing that) 4. if init.d operation is required use pre-start task of the vdsmd service. "Again, iiuc, this would mean every time vdsm service starts which would lead to VMs stopping" -- To view, visit http://gerrit.ovirt.org/20720 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8f72a68ad09566ba222aa45448c78d1577c40d21 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Ayal Baron <aba...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
