Yaniv Bronhaim has posted comments on this change.
Change subject: Introducing configurator package in vdsm-tool
......................................................................
Patch Set 19:
(3 comments)
....................................................
File init/systemd/systemd-vdsmd.in
Line 25:
Line 26: [ "$1" != "reconfigure" ] && usage_exit
Line 27: [ -n "$2" -a "$2" != "force" ] && usage_exit
Line 28:
Line 29: "@BINDIR@/vdsm-tool" configure ${2:+--force}
is-configured is already checked in the vdsm-tool configure flow.
force will be sent if specified.. what's wrong with "@BINDIR@/vdsm-tool"
configure ${2:+--force} -> no --force means won't be configured if relate
service runs..
....................................................
File lib/vdsm/tool/configurator.py
Line 159:
Line 160: sanlock = SanlockModuleConfigure()
Line 161: c[sanlock.getName()] = sanlock
Line 162:
Line 163: __configurers = setConfigurers()
because that's how I check if the module name as a configurer ->
for m in args.modules: (m is serice name)
if m not in __configurers, -> instead of doing
for c in __configurers: ->another redundant for loop
if m == c.getName() do ...
why does it matter anyway? what do you prefer?
Line 164:
Line 165:
Line 166: @vdsm.tool.expose("configure")
Line 167: def configure():
Line 170: """
Line 171: args = parse_configure_args()
Line 172: services_to_stop = []
Line 173: for m in args.modules:
Line 174: if m.getName() not in __configurers:
need to check: if m not in ... my bad.
Line 175: raise RuntimeError("Module %s does not exists")
Line 176: if not __configurers[m].isconfigured():
Line 177: services_to_stop.append(m.getServiceName())
Line 178: services_to_stop.append(m.getDependedServicesList())
--
To view, visit http://gerrit.ovirt.org/20100
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I16bf5894e7e55a84b4c2a0caacde383ae7c19242
Gerrit-PatchSet: 19
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybron...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshz...@linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
