Alon Bar-Lev has posted comments on this change. Change subject: Introducing configurator package in vdsm-tool ......................................................................
Patch Set 22: (2 comments) still missing the sanlock actual configuration... .................................................... Commit Message Line 9: This package union libvirt and sanlock configuration operations for now. Line 10: The package defines ModuleConfigure interface and API for modules configuration Line 11: tool. The format for the configure command is modified to: Line 12: Line 13: vdsm-tool configure --modules libvirt,sanlock --force --autoreset this is not true Line 14: Line 15: This module also provides is-configured and validate-config verbs with Line 16: the same syntax. Line 17: .................................................... File lib/vdsm/tool/configurator.py Line 57: Line 58: def getServices(self): Line 59: return ["supervdsmd", "vdsmd", "libvirtd"] Line 60: Line 61: def _exec_libvirt_configure(self, action, *args): no need for *args, you do not use it Line 62: """ Line 63: Invoke libvirt_configure.sh script Line 64: """ Line 65: if os.getuid() != 0: -- To view, visit http://gerrit.ovirt.org/20100 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I16bf5894e7e55a84b4c2a0caacde383ae7c19242 Gerrit-PatchSet: 22 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: Zhou Zheng Sheng <zhshz...@linux.vnet.ibm.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
