Nir Soffer has posted comments on this change.
Change subject: Invalidate filters on HSMs before rescanning extended VG
......................................................................
Patch Set 16:
(1 comment)
....................................................
File vdsm/storage/hsm.py
Line 2004: boolean
Line 2005: :rtype: dict
Line 2006: """
Line 2007: visibility = self.scanDevicesVisibility(guids)
Line 2008: lvm.invalidateFilter()
The code in scanDevicesVisibility is trying to handle the situation where new
pv is not known yet.
Now the question is if the filters are stale in the first case, where the
device is already knonw, but is not part of the vg. If they are stale, then
this patch is correct.
We use filters in two ways - some calls use shorter filters, where only the
relevant pvs are used, and some are using long filter with all the known
devices. The question is why the call failed - because we use a wrong short
filter (pv was not part of vg), or wrong long filter (unknown pv).
Line 2009: for guid in guids:
Line 2010: if visibility[guid]:
Line 2011: visibility[guid] = (os.stat('/dev/mapper/' +
guid).st_mode &
Line 2012: stat.S_IRUSR != 0)
--
To view, visit http://gerrit.ovirt.org/20552
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If1eeed1c203f2c8c73370987048565d665932299
Gerrit-PatchSet: 16
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Pavel Zhukov <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Eduardo <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Lee Yarwood <[email protected]>
Gerrit-Reviewer: Nir Soffer <[email protected]>
Gerrit-Reviewer: Pavel Zhukov <[email protected]>
Gerrit-Reviewer: Saggi Mizrahi <[email protected]>
Gerrit-Reviewer: Sergey Gotliv <[email protected]>
Gerrit-Reviewer: Tomáš Došek <[email protected]>
Gerrit-Reviewer: Yeela Kaplan <[email protected]>
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
