Dan Kenigsberg has posted comments on this change. Change subject: Invalidate filters on HSMs before rescanning extended VG ......................................................................
Patch Set 17: Code-Review-1 (2 comments) sorry, I still do not understand how this fix works. .................................................... Commit Message Line 12: group is marked as partial and domainMonitor selftest fails Line 13: (host goes to non-operational status). By design filter should be Line 14: invalidated if cmd returns nonzero code but vgs returns zero even if Line 15: devices are filtered . The only way to invalidate filter now is flush LvmCache. Line 16: To avoid perfomance issues the patch introduces public method for filter invalidation please keep shorter lines Line 17: and calls it from the getDevicesVisibility. As far as getDevicesVisibility Line 18: is called to all added devices this allows to reload filters every time Line 19: after new devices has been mapped but before vgscan. Line 20: Line 15: devices are filtered . The only way to invalidate filter now is flush LvmCache. Line 16: To avoid perfomance issues the patch introduces public method for filter invalidation Line 17: and calls it from the getDevicesVisibility. As far as getDevicesVisibility Line 18: is called to all added devices this allows to reload filters every time Line 19: after new devices has been mapped but before vgscan. Please state that getDevicesVisibility is called on the spm before extendSD, and explain what happens on hsm hosts (why don't they get into "partial" state?). Line 20: Line 21: Change-Id: If1eeed1c203f2c8c73370987048565d665932299 Line 22: Bugzilla-Url: https://bugzilla.redhat.com/1022976 -- To view, visit http://gerrit.ovirt.org/20552 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If1eeed1c203f2c8c73370987048565d665932299 Gerrit-PatchSet: 17 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Pavel Zhukov <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Eduardo <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Lee Yarwood <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Pavel Zhukov <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Sergey Gotliv <[email protected]> Gerrit-Reviewer: Tomáš Došek <[email protected]> Gerrit-Reviewer: Yeela Kaplan <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
