Ayal Baron has posted comments on this change.
Change subject: vm: fix _devices access in _highWrite
......................................................................
Patch Set 3:
(2 comments)
....................................................
File vdsm/vm.py
Line 2280: self.log.debug('new rtc offset %s', timeOffset)
Line 2281: with self._confLock:
Line 2282: self.conf['timeOffset'] = timeOffset
Line 2283:
Line 2284: def checkDrivesForExtension(self):
this isn't 'checking' this is actually extending
Line 2285: extend = []
Line 2286:
Line 2287: for drive in self._devices[DISK_DEVICES]:
Line 2288: if not drive.blockDev or drive.format != 'cow':
Line 2299: "capacity %s for volume %s on domain %s", alloc,
Line 2300: capacity, drive.domainID, drive.volumeID)
Line 2301: self.pause(pauseCode='EOTHER')
Line 2302:
Line 2303: for drive, capacity, alloc, physical in extend:
Sergey is correct, I don't deem it safe to extend any drive if VM has a device
with alloc > capacity
Line 2304: self.log.info('%s/%s apparent: %s capacity: %s, alloc:
%s, '
Line 2305: 'physical: %s', drive.domainID,
drive.volumeID,
Line 2306: drive.apparentsize, capacity, alloc,
physical)
Line 2307: self.extendDriveVolume(drive)
--
To view, visit http://gerrit.ovirt.org/20966
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4fd790986b81402847b06810529841cfd7bae119
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimo...@redhat.com>
Gerrit-Reviewer: Ayal Baron <aba...@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgot...@redhat.com>
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
