Nir Soffer has posted comments on this change. Change subject: vm: unify _highWrite and _onAbnormalStop ......................................................................
Patch Set 5: (1 comment) .................................................... File vdsm/vm.py Line 2298: drive.volumeID, drive.domainID, drive.apparentsize, capacity, Line 2299: alloc, physical) Line 2300: self.extendDriveVolume(drive) Line 2301: Line 2302: return len(extend) > 0 I see that there is another patch depending on this, that will use the extend list. However if this patch will be merge without the other then we are left with strange code. The extend list should be added by the other patch. Line 2303: Line 2304: def extendDriveVolume(self, vmDrive): Line 2305: if not vmDrive.blockDev: Line 2306: return -- To view, visit http://gerrit.ovirt.org/20966 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4fd790986b81402847b06810529841cfd7bae119 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <fsimo...@redhat.com> Gerrit-Reviewer: Ayal Baron <aba...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgot...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
