Nir Soffer has posted comments on this change. Change subject: Improve err msg when multipath cant access a pv ......................................................................
Patch Set 2: (3 comments) .................................................... Commit Message Line 3: AuthorDate: 2013-11-05 17:33:36 +0200 Line 4: Commit: Vered Volansky <vvola...@redhat.com> Line 5: CommitDate: 2013-11-10 13:40:15 +0200 Line 6: Line 7: Improve err msg when multipath cant access a pv Not sure why you are trying to keep this so short - the topic: prefix and using real words (error instead of err) is more important then whatever limits that may be here. Line 8: Line 9: InvalidPhysDev gave a cryptic error message - Invalid physical device. Line 10: The message was amended to "Multipath cannot access storage device" along Line 11: with the device name. The error key was changed according to the new Line 7: Improve err msg when multipath cant access a pv Line 8: Line 9: InvalidPhysDev gave a cryptic error message - Invalid physical device. Line 10: The message was amended to "Multipath cannot access storage device" along Line 11: with the device name. The error key was changed according to the new You cannot use engine terms here - there is no such thing as error key in vdsm. And the change was a rename - please be specific. Line 12: message content. The only thing needed here by the engine is the Line 13: error code, which was not changed in this patch. Line 14: Line 15: Change-Id: I648ee519873c51573e6e6306b79380f54bb25d2e .................................................... File vdsm/storage/storage_exception.py Line 1456: class InaccessiblePhysDev(StorageException): Line 1457: def __init__(self, pvname): Line 1458: self.value = "pvname=%s" % (pvname) Line 1459: code = 606 Line 1460: message = "Multipath cannot access storage device" Looking at it again, the term "storage device" is less correct then "physical device". Line 1461: Line 1462: Line 1463: class PartitionedPhysDev(StorageException): Line 1464: code = 607 -- To view, visit http://gerrit.ovirt.org/21089 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I648ee519873c51573e6e6306b79380f54bb25d2e Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vered Volansky <vvola...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Vered Volansky <vvola...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
