Dan Kenigsberg has posted comments on this change. Change subject: xmlrpc: Parsing error logging enhancement - vdsClient ......................................................................
Patch Set 7: Code-Review-1 (2 comments) .................................................... File lib/vdsm/vdscli.py.in Line 24: import os Line 25: import re Line 26: import sys Line 27: import types Line 28: from vdsm import SecureXMLRPCServer imports from vdsm should com last. Line 29: from xml.parsers.expat import ExpatError Line 30: Line 31: d_useSSL = False Line 32: d_tsPath = '@TRUSTSTORE@' Line 42: transport) Line 43: Line 44: def wrapped_parse_response(self, *args, **kwargs): Line 45: try: Line 46: return self._orig_parse_response(*args[1:], **kwargs) why [1:]? was it tested? could you add a unit test that proves it? Line 47: except ExpatError: Line 48: sys.stderr.write('Parsing error was thrown during parsing ' Line 49: 'response when provided: {}'.format(args[1])) Line 50: raise -- To view, visit http://gerrit.ovirt.org/20627 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ife29c4f7749b9cd8a4ad892f486d91509e505ae4 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Saggi Mizrahi <smizr...@redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: mooli tayer <mta...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches