Dan Kenigsberg has posted comments on this change.
Change subject: xmlrpc: Parsing error logging enhancement - vdsClient
......................................................................
Patch Set 5: Code-Review-1
(2 comments)
....................................................
File lib/vdsm/vdscli.py.in
Line 34:
Line 35:
Line 36: class TransportWrapper:
Line 37: def __init__(self, transport):
Line 38: self._parse = transport.parse_response
_orig_parse_response would be a better name.
Line 39: transport.parse_response = lambda *args, **kwargs: {
Line 40: self.wrapping_func(args, kwargs)
Line 41: }
Line 42:
Line 39: transport.parse_response = lambda *args, **kwargs: {
Line 40: self.wrapping_func(args, kwargs)
Line 41: }
Line 42:
Line 43: def _wrap(self, func, args, kwargs):
Please have a specific "wrapped_parse_response" function. No need for this
general wrapper. It would save us the lambda and "wrapping_func".
Line 44: try:
Line 45: return func(*args, **kwargs)
Line 46: except ExpatError as e:
Line 47: sys.stderr.write('Parsing error was thrown during parsing '
--
To view, visit http://gerrit.ovirt.org/20627
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ife29c4f7749b9cd8a4ad892f486d91509e505ae4
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Piotr Kliczewski <[email protected]>
Gerrit-Reviewer: Saggi Mizrahi <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: mooli tayer <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
