Alon Bar-Lev has posted comments on this change.
Change subject: Fail pre-start run after configure libvirt
......................................................................
Patch Set 1:
(1 comment)
....................................................
File init/vdsmd_init_common.sh.in
Line 54: }
Line 55:
Line 56:
Line 57: task_reconfigure_libvirt(){
Line 58: "$VDSM_TOOL" libvirt-configure | grep -q 'To start working' &&
return 1
can't you modify the tool to return non zero exit code? it is better than
greping.
Line 59: return 0
Line 60: }
Line 61:
Line 62:
--
To view, visit http://gerrit.ovirt.org/21356
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8216f9556e6ef4df96977db494c5b5169bfae80a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.3
Gerrit-Owner: Yaniv Bronhaim <ybron...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
