Yaniv Bronhaim has posted comments on this change. Change subject: Fail pre-start run after configure libvirt ......................................................................
Patch Set 2: (1 comment) .................................................... File init/vdsmd_init_common.sh.in Line 58: if "$VDSM_TOOL" libvirt-configure | grep -q 'is done'; then Line 59: echo "Reconfigured libvirt. Please perform: " \ Line 60: "'vdsm-tool libvirt-configure-services-restart' " \ Line 61: "and start vdsmd again" Line 62: return 1 Prefer not, changing ret code means changing in the update flow and might be more usages that I don't think of. So as minor as I can, I prefer to leave this change as is. And, in ovirt-3.3 we don't have the print in the tool that says to use vdsm-tool verb to reset related services, so I'll need to add it also there.. Line 63: fi Line 64: return 0 Line 65: } Line 66: -- To view, visit http://gerrit.ovirt.org/21356 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8216f9556e6ef4df96977db494c5b5169bfae80a Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.3 Gerrit-Owner: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
